[all-commits] [llvm/llvm-project] 1645f5: [gn build] replace llvm_allow_tardy_revision with ...

[Nico Weber via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 1645f5e496b93c534069f03886c97be85d5de35d
      https://github.com/llvm/llvm-project/commit/1645f5e496b93c534069f03886c97be85d5de35d
  Author: Nico Weber <thakis at chromium.org>
  Date:   2020-01-16 (Thu, 16 Jan 2020)

  Changed paths:
    M llvm/utils/gn/build/write_vcsrevision.gni
    M llvm/utils/gn/build/write_vcsrevision.py

  Log Message:
  -----------
  [gn build] replace llvm_allow_tardy_revision with llvm_append_vc_rev

Previously, the gn build would create VCSRevision.h / VCSVersion.h
files with some LLD_REVISION / LLVM_REVISION / CLANG_REVISION but
by default wouldn't add a dependency on .git/logs/HEAD so that
the step doesn't rerun after every branch switch or every pull.

That's bad for deterministic builds, and having --version print
some arbitrarily old revision isn't great either.

Instead, move to the model that the cmake build (now) uses fairly
consistently: If llvm_append_vc_rev is set, include the revision,
else don't.

Since the GN build is focused on developers, set llvm_append_vc_rev
to false instead of true by default (different from the cmake build),
so that things don't rebuild after every branch switch and every
pull.

While here, also remove some pre-monorepo code.

Differential Revision: https://reviews.llvm.org/D72859