[all-commits] [llvm/llvm-project] fb9413: Remove some SVN-specific code.

Nico Weber via All-commits all-commits at lists.llvm.org
Thu Jan 16 08:02:58 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: fb9413cb84cc422426c81f6464083795e781566b
      https://github.com/llvm/llvm-project/commit/fb9413cb84cc422426c81f6464083795e781566b
  Author: Nico Weber <thakis at chromium.org>
  Date:   2020-01-16 (Thu, 16 Jan 2020)

  Changed paths:
    M clang/lib/Basic/Version.cpp

  Log Message:
  -----------
  Remove some SVN-specific code.

$URL$ is an SVN keyword substitution enabled via
`svn propset svn:keywords "URL" tools/clang/lib/Basic/Version.cpp`.
Now that we no longer use SVN, it's no longer being replaced by
anything, and we no longer offer svn exports. So remove the
$URL$-specific logic.

The "cfe" path prefix removal also no longer makes sense now that
we're on git: Both CLANG_REPOSITORY and LLVM_REPOSITORY are usually
set to https://github.com/llvm/llvm-project.git

So remove that too, and remove the "llvm" prefix removal for symmetry.
With the github url, "llvm" _is_ found in the string, but not in
the place the function expected. Nobody noticed since the llvm
repository path is only used if CLANG_REVISION and LLVM_REVISION are
different, which in the git monorepo world they never should be.
(I might remove the "// Support LLVM in a separate repository"
block in a separate commit.)

Differential Revision: https://reviews.llvm.org/D72848




More information about the All-commits mailing list