[all-commits] [llvm/llvm-project] 15a6df: [lldb/DWARF/test] Freshen up debug_names tests

[Pavel Labath via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 15a6df52efaa74308bfdcd03718a84ac893b40d8
      https://github.com/llvm/llvm-project/commit/15a6df52efaa74308bfdcd03718a84ac893b40d8
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-01-16 (Thu, 16 Jan 2020)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/lang/c/forward/TestForwardDeclaration.py
    M lldb/test/Shell/SymbolFile/DWARF/debug-names-compressed.cpp
    M lldb/test/Shell/SymbolFile/DWARF/dwarf5-index-is-used.cpp
    M lldb/test/Shell/SymbolFile/DWARF/dwarf5-partial-index.cpp
    M lldb/test/Shell/SymbolFile/DWARF/find-basic-function.cpp
    M lldb/test/Shell/SymbolFile/DWARF/find-basic-namespace.cpp
    M lldb/test/Shell/SymbolFile/DWARF/find-basic-type.cpp
    M lldb/test/Shell/SymbolFile/DWARF/find-basic-variable.cpp
    M lldb/test/Shell/SymbolFile/DWARF/find-function-regex.cpp
    M lldb/test/Shell/SymbolFile/DWARF/find-method.cpp
    M lldb/test/Shell/SymbolFile/DWARF/find-variable-dwo.cpp
    M lldb/test/Shell/SymbolFile/DWARF/find-variable-file.cpp

  Log Message:
  -----------
  [lldb/DWARF/test] Freshen up debug_names tests

These tests used "clang -mllvm -accel-tables=Dwarf" as a way to
guarantee that clang will emit the debug_names table. Unfortunately,
a change it clang made that insufficient (-gpubnames is required now
too), which rendered these tests ineffective. Since lldb automatically
falls back to the manual index, the tests didn't fail and this change
went largely unnoticed.

This patch updates the tests to really use debug_names (-gdwarf-5
-gpubnames) is the combination that works now, and it adds additional
checks to ensure the section is actually emitted.

Fortunately, no regressions crept in while these tests were disabled.