[all-commits] [llvm/llvm-project] 4b6d9a: Make lld cmake not compute commit revision twice

Nico Weber via All-commits all-commits at lists.llvm.org
Thu Jan 16 06:56:07 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 4b6d9ac392613e33c61ff3f91ade6c477d8396fa
      https://github.com/llvm/llvm-project/commit/4b6d9ac392613e33c61ff3f91ade6c477d8396fa
  Author: Nico Weber <thakis at chromium.org>
  Date:   2020-01-16 (Thu, 16 Jan 2020)

  Changed paths:
    M lld/CMakeLists.txt
    M lld/include/lld/Common/Version.inc.in
    R llvm/utils/GetRepositoryPath
    M llvm/utils/gn/secondary/lld/include/lld/Common/BUILD.gn

  Log Message:
  -----------
  Make lld cmake not compute commit revision twice

r354605 moved LLD to the unified revision handling introduced in
rL353268 / r352729 and removed uses of LLD_REPOSITORY_STRING and
LLD_REVISION_STRING.

After this change, we no longer compute the (now-unused) values
of these two variables.

Since this removes the only use of llvm/utils/GetRepositoryPath,
remove that too (it's redundant with the system added in r354605).

While here, also remove LLD_VERSION_MAJOR and LLD_VERSION_MINOR.
Their uses were removed in r285163.

Also remove LLD_VERSION from Version.inc which as far as I can
tell has been unused since the file was added in r219277.

No behavior change.

Differential Revision: https://reviews.llvm.org/D72803




More information about the All-commits mailing list