[all-commits] [llvm/llvm-project] 25e993: GlobalISel: Handle more cases of G_SEXT narrowing

Matt Arsenault via All-commits all-commits at lists.llvm.org
Wed Jan 15 15:33:20 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 25e9938a45e8dfde752a4e93c48ff0184d4784d9
      https://github.com/llvm/llvm-project/commit/25e9938a45e8dfde752a4e93c48ff0184d4784d9
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-01-15 (Wed, 15 Jan 2020)

  Changed paths:
    M llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
    M llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-sext.mir

  Log Message:
  -----------
  GlobalISel: Handle more cases of G_SEXT narrowing

This now develops the same problem G_ZEXT/G_ANYEXT have where the
requested type is assumed to be the source type. This will be fixed
separately by creating intermediate merges.


  Commit: eef92f25ccf186935008c98f8147ad2ee178dcbb
      https://github.com/llvm/llvm-project/commit/eef92f25ccf186935008c98f8147ad2ee178dcbb
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-01-15 (Wed, 15 Jan 2020)

  Changed paths:
    M llvm/include/llvm/IR/IntrinsicsAMDGPU.td
    M llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUISelLowering.h
    M llvm/lib/Target/AMDGPU/AMDGPUInstrInfo.td
    M llvm/lib/Target/AMDGPU/SIISelLowering.cpp
    M llvm/lib/Target/AMDGPU/SIInstrInfo.td
    M llvm/lib/Target/AMDGPU/SIInstructions.td

  Log Message:
  -----------
  AMDGPU: Remove custom node for exports

I'm mildly worried about potentially reordering exp/exp_done with
IntrWriteMem on the intrinsic.

Requires hacking out the illegal type on SI, so manually select that
case during lowering.


  Commit: 711a17afaff276f816aca5dc4a68fae4e17a2c12
      https://github.com/llvm/llvm-project/commit/711a17afaff276f816aca5dc4a68fae4e17a2c12
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-01-15 (Wed, 15 Jan 2020)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
    M llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-amdgcn.exp.mir

  Log Message:
  -----------
  AMDGPU/GlobalISel: Select exp with patterns

This does produce slightly different code. Now a unique IMPLICIT_DEF
is emitted for each of the implicit_def operands, rather than reusing
the same one.


Compare: https://github.com/llvm/llvm-project/compare/daab9227ff01...711a17afaff2


More information about the All-commits mailing list