[all-commits] [llvm/llvm-project] 441410: [ELF] Avoid false-positive assert in getErrPlace()

Alexander Richardson via All-commits all-commits at lists.llvm.org
Wed Jan 15 06:32:55 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 441410be471d5d0a5d1d47cf363de155e397a0c2
      https://github.com/llvm/llvm-project/commit/441410be471d5d0a5d1d47cf363de155e397a0c2
  Author: Alex Richardson <Alexander.Richardson at cl.cam.ac.uk>
  Date:   2020-01-15 (Wed, 15 Jan 2020)

  Changed paths:
    M lld/ELF/Target.cpp
    M lld/test/ELF/mips-jalr-non-functions.s

  Log Message:
  -----------
  [ELF] Avoid false-positive assert in getErrPlace()

This assertion was added as part of D70659 but did not account for .bss
input sections. I noticed that this assert was incorrectly triggering
while building FreeBSD for MIPS64. Fixed by relaxing the assert to also
account for SHT_NOBITS input sections and adjust the test
mips-jalr-non-function.s to link a file with a .bss section first.

Reviewed By: MaskRay, grimar
Differential Revision: https://reviews.llvm.org/D72567




More information about the All-commits mailing list