[all-commits] [llvm/llvm-project] 2d287b: [nfc][libomptarget] Refactor amdgcn target_impl

Jon Chesterfield via All-commits all-commits at lists.llvm.org
Tue Jan 14 11:27:20 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 2d287bec3c5b63b7df9946163ba02987858b1736
      https://github.com/llvm/llvm-project/commit/2d287bec3c5b63b7df9946163ba02987858b1736
  Author: Jon Chesterfield <jonathanchesterfield at gmail.com>
  Date:   2020-01-14 (Tue, 14 Jan 2020)

  Changed paths:
    M openmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt
    M openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.h
    A openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.hip

  Log Message:
  -----------
  [nfc][libomptarget] Refactor amdgcn target_impl

Summary:
[nfc][libomptarget] Refactor amdgcn target_impl

Removes references to internal libraries from the header
Standardises on C++ mangling for all the target_impl functions
Update comment block
clang-format
Move some functions into a new target_impl.hip source file

This lays the groundwork for implementing the remaining unresolved
symbols in the target_impl.hip source.

Reviewers: jdoerfert, grokos, ABataev, ronlieb

Reviewed By: jdoerfert

Subscribers: jvesely, mgorny, jfb, openmp-commits

Tags: #openmp

Differential Revision: https://reviews.llvm.org/D72712




More information about the All-commits mailing list