[all-commits] [llvm/llvm-project] 2cefb9: [ThinLTO/WPD] Remove an overly-aggressive assert

[Teresa Johnson via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 2cefb93951cca01dcdde6fe5c7354dc8bcd796d6
      https://github.com/llvm/llvm-project/commit/2cefb93951cca01dcdde6fe5c7354dc8bcd796d6
  Author: Teresa Johnson <tejohnson at google.com>
  Date:   2020-01-14 (Tue, 14 Jan 2020)

  Changed paths:
    M llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp
    A llvm/test/ThinLTO/X86/Inputs/devirt_external_comdat_same_guid.ll
    A llvm/test/ThinLTO/X86/devirt_external_comdat_same_guid.ll

  Log Message:
  -----------
  [ThinLTO/WPD] Remove an overly-aggressive assert

Summary:
An assert added to the index-based WPD was trying to verify that we only
have multiple vtables for a given guid when they are all non-external
linkage. This is too conservative because we may have multiple external
vtable with the same guid when they are in comdat. Remove the assert,
as we don't have comdat information in the index, the linker should
issue an error in this case.

See discussion on D71040 for more information.

Reviewers: evgeny777, aganea

Subscribers: mehdi_amini, inglorion, hiraditya, steven_wu, dexonsmith, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D72648