[all-commits] [llvm/llvm-project] c8a14c: [IR] fix potential crash in Constant::isElementWis...

[RotateRight via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c8a14c2d4773841daa303736332d0038ead6f36a
      https://github.com/llvm/llvm-project/commit/c8a14c2d4773841daa303736332d0038ead6f36a
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2020-01-14 (Tue, 14 Jan 2020)

  Changed paths:
    M llvm/lib/IR/Constants.cpp
    M llvm/unittests/IR/ConstantsTest.cpp

  Log Message:
  -----------
  [IR] fix potential crash in Constant::isElementWiseEqual()

There's only one user of this API currently, and it seems
impossible that it would compare values with different types.

But that's not true in general, so we need to make sure the
types are the same.

As denoted by the FIXME comments, we will also crash on FP
values. That's what brought me here, but we can make that a
follow-up patch.