[all-commits] [llvm/llvm-project] a705cf: Expression eval lookup speedup by not returning me...

Pavel Labath via All-commits all-commits at lists.llvm.org
Tue Jan 14 05:57:27 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a705cf1acbe94498f7fcca4e89be6d4820271227
      https://github.com/llvm/llvm-project/commit/a705cf1acbe94498f7fcca4e89be6d4820271227
  Author: Levon Ter-Grigoryan <patriosthegreat at protonmail.ch>
  Date:   2020-01-14 (Tue, 14 Jan 2020)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/lang/cpp/printf/TestPrintf.py
    M lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp
    M lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp
    M lldb/test/Shell/SymbolFile/DWARF/find-basic-function.cpp

  Log Message:
  -----------
  Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions

Summary:
This change is connected with
https://reviews.llvm.org/D69843

In large codebases, we sometimes see Module::FindFunctions (when called from
ClangExpressionDeclMap::FindExternalVisibleDecls) returning huge amounts of
functions.

In current fix I trying to return only function_fullnames from ManualDWARFIndex::GetFunctions when eFunctionNameTypeFull is passed as argument.

Reviewers: labath, jarin, aprantl

Reviewed By: labath

Subscribers: shafik, clayborg, teemperor, arphaman, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D70846




More information about the All-commits mailing list