[all-commits] [llvm/llvm-project] d6ea8f: [mlir] Fix translation of splat constants to LLVM IR

ftynse via All-commits all-commits at lists.llvm.org
Tue Jan 14 03:38:09 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d6ea8ff0d74bfe5cd181ccfe91c2c300c5f7a35d
      https://github.com/llvm/llvm-project/commit/d6ea8ff0d74bfe5cd181ccfe91c2c300c5f7a35d
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2020-01-14 (Tue, 14 Jan 2020)

  Changed paths:
    M mlir/lib/Target/LLVMIR/ModuleTranslation.cpp
    M mlir/test/Target/llvmir.mlir

  Log Message:
  -----------
  [mlir] Fix translation of splat constants to LLVM IR

Summary:
When converting splat constants for nested sequential LLVM IR types wrapped in
MLIR, the constant conversion was erroneously assuming it was always possible
to recursively construct a constant of a sequential type given only one value.
Instead, wait until all sequential types are unpacked recursively before
constructing a scalar constant and wrapping it into the surrounding sequential
type.

Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, aartbik, liufengdb, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D72688




More information about the All-commits mailing list