[all-commits] [llvm/llvm-project] 9492e9: [lldb][NFC] Cleanup ClangASTContext::CompleteTagDe...

Raphael Isemann via All-commits all-commits at lists.llvm.org
Tue Jan 14 03:04:47 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 9492e9d8cfd356109276da5aa926b297db0e16db
      https://github.com/llvm/llvm-project/commit/9492e9d8cfd356109276da5aa926b297db0e16db
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2020-01-14 (Tue, 14 Jan 2020)

  Changed paths:
    M lldb/source/Symbol/ClangASTContext.cpp

  Log Message:
  -----------
  [lldb][NFC] Cleanup ClangASTContext::CompleteTagDeclarationDefinition

Makes this function exit early instead of nesting if statements.

Also removed all the if (tag_type->getDecl()) checks. If we created
a TagType with a nullptr as a Decl then Clang would have already
deferenced that nullptr during TagType creation so there is no point
in gracefully handling a nullptr here.




More information about the All-commits mailing list