[all-commits] [llvm/llvm-project] d8ffd6: [lldb][NFC] Rewrite python_api/rdar-12481949 test

Raphael Isemann via All-commits all-commits at lists.llvm.org
Tue Jan 14 01:11:05 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d8ffd601d523fa0c0a55e25e62af9ffaa618629d
      https://github.com/llvm/llvm-project/commit/d8ffd601d523fa0c0a55e25e62af9ffaa618629d
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2020-01-14 (Tue, 14 Jan 2020)

  Changed paths:
    A lldb/packages/Python/lldbsuite/test/python_api/get-value-32bit-int/Makefile
    A lldb/packages/Python/lldbsuite/test/python_api/get-value-32bit-int/TestGetValue32BitInt.py
    A lldb/packages/Python/lldbsuite/test/python_api/get-value-32bit-int/main.cpp
    R lldb/packages/Python/lldbsuite/test/python_api/rdar-12481949/Makefile
    R lldb/packages/Python/lldbsuite/test/python_api/rdar-12481949/Test-rdar-12481949.py
    R lldb/packages/Python/lldbsuite/test/python_api/rdar-12481949/main.cpp

  Log Message:
  -----------
  [lldb][NFC] Rewrite python_api/rdar-12481949 test

Summary:
This renames the test `rdar-12481949` to `get-value-32bit-int` as it just tests that we return the
correct result get calling GetValueAsSigned/GetValueAsUnsigned on 32-bit integers.

It also deletes all the strange things going on in this test including resetting the data formatters (which are to my
knowledge not used to calculate scalar values) and testing Python's long integers (let's just assume that our Python
distribution works correctly). Also modernises the setup code.

Reviewers: labath, aprantl

Reviewed By: aprantl

Subscribers: JDevlieghere, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D72593




More information about the All-commits mailing list