[all-commits] [llvm/llvm-project] 0950de: [AMDGPU] Improve error checking in gfx10 assembler...

[jayfoad via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0950de264e37264b9f767a898bd839d9fcb7328f
      https://github.com/llvm/llvm-project/commit/0950de264e37264b9f767a898bd839d9fcb7328f
  Author: Jay Foad <jay.foad at amd.com>
  Date:   2020-01-14 (Tue, 14 Jan 2020)

  Changed paths:
    M llvm/test/MC/AMDGPU/gfx10_asm_all.s

  Log Message:
  -----------
  [AMDGPU] Improve error checking in gfx10 assembler tests

Summary:
This adds checks that the expected error was actually reported against
the correct instruction, and fixes a couple of problems that that showed
up: one incorrect W32-ERR:

 v_cmp_class_f16_sdwa vcc, v1, v2 src0_sel:DWORD src1_sel:DWORD
 // W64: encoding: [0xf9,0x04,0x1e,0x7d,0x01,0x00,0x06,0x06]
-// W32-ERR: error: invalid operand for instruction
+// W32-ERR: error: {{instruction not supported on this GPU|invalid operand for instruction}}

and one missing W32-ERR:

 v_cmp_class_f16_sdwa s[6:7], v1, v2 src0_sel:DWORD src1_sel:DWORD
 // W64: encoding: [0xf9,0x04,0x1e,0x7d,0x01,0x86,0x06,0x06]
+// W32-ERR: error: invalid operand for instruction

Reviewers: rampitec, arsenm

Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, dstuttard, tpr, t-tye, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D72611


  Commit: 440ce5164f52a6b7cdf70322cc1c95656cac9aa9
      https://github.com/llvm/llvm-project/commit/440ce5164f52a6b7cdf70322cc1c95656cac9aa9
  Author: Jay Foad <jay.foad at amd.com>
  Date:   2020-01-14 (Tue, 14 Jan 2020)

  Changed paths:
    M llvm/test/MC/AMDGPU/gfx10_asm_all.s
    M llvm/test/MC/Disassembler/AMDGPU/gfx10_dasm_all.txt

  Log Message:
  -----------
  [AMDGPU] Remove duplicate gfx10 assembler and disassembler tests

Summary: Depends on D72611.

Reviewers: rampitec, arsenm

Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, dstuttard, tpr, t-tye, jfb, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D72616


Compare: https://github.com/llvm/llvm-project/compare/63c3691f7917...440ce5164f52