[all-commits] [llvm/llvm-project] 810b28: [ItaniumCXXABI] Make tls wrappers properly comdat

Martin Storsjö via All-commits all-commits at lists.llvm.org
Mon Jan 13 13:36:57 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 810b28edb3f64569054d49d6ddf18a4d802d9b11
      https://github.com/llvm/llvm-project/commit/810b28edb3f64569054d49d6ddf18a4d802d9b11
  Author: Martin Storsjö <martin at martin.st>
  Date:   2020-01-13 (Mon, 13 Jan 2020)

  Changed paths:
    M clang/lib/CodeGen/ItaniumCXXABI.cpp
    M clang/test/CodeGenCXX/cxx11-thread-local-reference.cpp
    M clang/test/CodeGenCXX/cxx11-thread-local.cpp
    M clang/test/CodeGenCXX/tls-init-funcs.cpp
    M clang/test/OpenMP/threadprivate_codegen.cpp

  Log Message:
  -----------
  [ItaniumCXXABI] Make tls wrappers properly comdat

Just marking a symbol as weak_odr/linkonce_odr isn't enough for
actually tolerating multiple copies of it at linking on windows,
it has to be made a proper comdat; make it comdat for all platforms
for consistency.

This should hopefully fix
https://bugzilla.mozilla.org/show_bug.cgi?id=1566288.

Differential Revision: https://reviews.llvm.org/D71572




More information about the All-commits mailing list