[all-commits] [llvm/llvm-project] 4268e4: [mlir] Change the syntax of AffineMapAttr and Inte...

[River Riddle via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 4268e4f4b84b85266426e99050d31ec63f3ce8aa
      https://github.com/llvm/llvm-project/commit/4268e4f4b84b85266426e99050d31ec63f3ce8aa
  Author: River Riddle <riverriddle at google.com>
  Date:   2020-01-13 (Mon, 13 Jan 2020)

  Changed paths:
    M mlir/docs/Dialects/Affine.md
    M mlir/docs/Dialects/Standard.md
    M mlir/docs/LangRef.md
    M mlir/include/mlir/IR/DialectImplementation.h
    M mlir/include/mlir/IR/OpImplementation.h
    M mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
    M mlir/lib/IR/AsmPrinter.cpp
    M mlir/lib/Parser/Parser.cpp
    M mlir/lib/Parser/TokenKinds.def
    M mlir/test/AffineOps/canonicalize.mlir
    M mlir/test/AffineOps/dma.mlir
    M mlir/test/AffineOps/inlining.mlir
    M mlir/test/AffineOps/invalid.mlir
    M mlir/test/AffineOps/load-store-invalid.mlir
    M mlir/test/AffineOps/load-store.mlir
    M mlir/test/AffineOps/memref-stride-calculation.mlir
    M mlir/test/AffineOps/ops.mlir
    M mlir/test/Conversion/StandardToLLVM/convert-memref-ops.mlir
    M mlir/test/Conversion/StandardToLLVM/convert-to-llvmir.mlir
    M mlir/test/Conversion/StandardToLLVM/standard-to-llvm.mlir
    M mlir/test/Conversion/VectorToLoops/vector-to-loops.mlir
    M mlir/test/Dialect/Linalg/affine.mlir
    M mlir/test/Dialect/Linalg/fusion.mlir
    M mlir/test/Dialect/Linalg/invalid.mlir
    M mlir/test/Dialect/Linalg/llvm.mlir
    M mlir/test/Dialect/Linalg/loops.mlir
    M mlir/test/Dialect/Linalg/promote.mlir
    M mlir/test/Dialect/Linalg/roundtrip.mlir
    M mlir/test/Dialect/Linalg/tile.mlir
    M mlir/test/Dialect/Linalg/tile_conv.mlir
    M mlir/test/Dialect/Linalg/tile_indexed_generic.mlir
    M mlir/test/Dialect/Linalg/transform-patterns.mlir
    M mlir/test/Dialect/SPIRV/composite-ops.mlir
    M mlir/test/Dialect/VectorOps/invalid.mlir
    M mlir/test/Dialect/VectorOps/ops.mlir
    M mlir/test/Dialect/VectorOps/vector-transforms.mlir
    M mlir/test/EDSC/builder-api-test.cpp
    M mlir/test/IR/affine-map.mlir
    M mlir/test/IR/core-ops.mlir
    M mlir/test/IR/invalid-affinemap.mlir
    M mlir/test/IR/invalid-ops.mlir
    M mlir/test/IR/invalid.mlir
    M mlir/test/IR/locations.mlir
    M mlir/test/IR/memory-ops.mlir
    M mlir/test/IR/opaque_locations.mlir
    M mlir/test/IR/parser.mlir
    M mlir/test/IR/pretty-locations.mlir
    M mlir/test/IR/print-op-local-scope.mlir
    M mlir/test/Transforms/Vectorize/compose_maps.mlir
    M mlir/test/Transforms/Vectorize/normalize_maps.mlir
    M mlir/test/Transforms/Vectorize/vectorize_1d.mlir
    M mlir/test/Transforms/Vectorize/vectorize_2d.mlir
    M mlir/test/Transforms/Vectorize/vectorize_3d.mlir
    M mlir/test/Transforms/Vectorize/vectorize_outer_loop_2d.mlir
    M mlir/test/Transforms/Vectorize/vectorize_outer_loop_transpose_2d.mlir
    M mlir/test/Transforms/Vectorize/vectorize_transpose_2d.mlir
    M mlir/test/Transforms/affine-data-copy.mlir
    M mlir/test/Transforms/affine-loop-invariant-code-motion.mlir
    M mlir/test/Transforms/canonicalize.mlir
    M mlir/test/Transforms/constant-fold.mlir
    M mlir/test/Transforms/cse.mlir
    M mlir/test/Transforms/dma-generate.mlir
    M mlir/test/Transforms/loop-fusion-slice-computation.mlir
    M mlir/test/Transforms/loop-fusion.mlir
    M mlir/test/Transforms/loop-invariant-code-motion.mlir
    M mlir/test/Transforms/loop-tiling.mlir
    M mlir/test/Transforms/lower-affine.mlir
    M mlir/test/Transforms/memref-bound-check.mlir
    M mlir/test/Transforms/memref-dataflow-opt.mlir
    M mlir/test/Transforms/memref-dependence-check.mlir
    M mlir/test/Transforms/memref-normalize.mlir
    M mlir/test/Transforms/pipeline-data-transfer.mlir
    M mlir/test/Transforms/simplify-affine-structures.mlir
    M mlir/test/Transforms/slicing-utils.mlir
    M mlir/test/Transforms/strip-debuginfo.mlir
    M mlir/test/Transforms/unroll-jam.mlir
    M mlir/test/Transforms/unroll.mlir
    M mlir/test/mlir-cpu-runner/linalg_integration_test.mlir

  Log Message:
  -----------
  [mlir] Change the syntax of AffineMapAttr and IntegerSetAttr to avoid conflicts with function types.

Summary: The current syntax for AffineMapAttr and IntegerSetAttr conflict with function types, making it currently impossible to round-trip function types(and e.g. FuncOp) in the IR. This revision changes the syntax for the attributes by wrapping them in a keyword. AffineMapAttr is wrapped with `affine_map<>` and IntegerSetAttr is wrapped with `affine_set<>`.

Reviewed By: nicolasvasilache, ftynse

Differential Revision: https://reviews.llvm.org/D72429