[all-commits] [llvm/llvm-project] a0f460: Rework be15dfa88fb1 such that it works with Global...

Daniel Sanders via All-commits all-commits at lists.llvm.org
Mon Jan 13 12:19:48 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a0f4600f4f0ece1d4779544513f5a70c6f0d78bf
      https://github.com/llvm/llvm-project/commit/a0f4600f4f0ece1d4779544513f5a70c6f0d78bf
  Author: Daniel Sanders <daniel_l_sanders at apple.com>
  Date:   2020-01-13 (Mon, 13 Jan 2020)

  Changed paths:
    M llvm/include/llvm/CodeGen/ISDOpcodes.h
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

  Log Message:
  -----------
  Rework be15dfa88fb1 such that it works with GlobalISel which doesn't use EVT

Summary:
be15dfa88fb1 broke GlobalISel's usage of getSetCCInverse() which currently
appears to be limited to our out-of-tree backend. GlobalISel doesn't use
EVT's and isn't able to derive them from the information it has as it
doesn't distinguish between integer and floating point types (that
distinction is made by operations rather than values). Bring back the
bool version of getSetCCInverse() in a way that doesn't break the intent
of be15dfa88fb1 but also allows GlobalISel to continue using it.

Reviewers: spatel, bogner, arichardson

Reviewed By: arichardson

Subscribers: rovka, hiraditya, Petar.Avramovic, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D72309




More information about the All-commits mailing list