[all-commits] [llvm/llvm-project] f5465e: [clangd] Include expression in DecltypeTypeLoc sou...

kadir çetinkaya via All-commits all-commits at lists.llvm.org
Mon Jan 13 11:34:46 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: f5465e74ef4c9e24f867002aa598dc9e6481ead3
      https://github.com/llvm/llvm-project/commit/f5465e74ef4c9e24f867002aa598dc9e6481ead3
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2020-01-13 (Mon, 13 Jan 2020)

  Changed paths:
    M clang-tools-extra/clangd/Selection.cpp
    M clang-tools-extra/clangd/unittests/SelectionTests.cpp

  Log Message:
  -----------
  [clangd] Include expression in DecltypeTypeLoc sourcerange while building SelectionTree

Summary:
Currently AST only contains the location for `decltype` keyword,
therefore we were skipping expressions inside decltype while building selection
tree.

This patch extends source range in such cases to contain the expression as well.
A proper fix would require changes to Sema and DecltypeTypeLoc to contain these
location information.

Fixes https://github.com/clangd/clangd/issues/250.

Reviewers: sammccall

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D72594




More information about the All-commits mailing list