[all-commits] [llvm/llvm-project] b6ffa2: [DebugInfo][Support] Replace DWARFDataExtractor si...

[James Henderson via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: b6ffa2fe1250a8f506cc66044275b0bced56059e
      https://github.com/llvm/llvm-project/commit/b6ffa2fe1250a8f506cc66044275b0bced56059e
  Author: James Henderson <james.henderson at sony.com>
  Date:   2020-01-13 (Mon, 13 Jan 2020)

  Changed paths:
    M llvm/include/llvm/DebugInfo/DWARF/DWARFDataExtractor.h
    M llvm/include/llvm/Support/DataExtractor.h
    M llvm/unittests/Support/DataExtractorTest.cpp

  Log Message:
  -----------
  [DebugInfo][Support] Replace DWARFDataExtractor size function

This patch adds a new size function to the base DataExtractor class,
which removes the need for the DWARFDataExtractor size function.

It is unclear why DWARFDataExtractor's size function returned zero in
some circumstances (i.e. when it is constructed without a section, and
with a different data source instead), so that behaviour has changed.
The old behaviour could cause an assertion in the debug line parser, as
the size did not reflect the actual data available, and could be lower
than the current offset being parsed.

Reviewed by: dblaikie

Differential Revision: https://reviews.llvm.org/D72337