[all-commits] [llvm/llvm-project] d692f0: [X86] Don't call LowerSETCC from LowerSELECT for S...

topperc via All-commits all-commits at lists.llvm.org
Sat Jan 11 20:44:17 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d692f0f6c8c12316d559b9a638a2cb9fbd0c263d
      https://github.com/llvm/llvm-project/commit/d692f0f6c8c12316d559b9a638a2cb9fbd0c263d
  Author: Craig Topper <craig.topper at gmail.com>
  Date:   2020-01-11 (Sat, 11 Jan 2020)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp

  Log Message:
  -----------
  [X86] Don't call LowerSETCC from LowerSELECT for STRICT_FSETCC/STRICT_FSETCCS nodes.

This causes the STRICT_FSETCC/STRICT_FSETCCS nodes to lowered
early while lowering SELECT, but the output chain doesn't get
connected. Then we visit the node again when it is its turn
because we haven't replaced the use of the chain result. In the
case of the fp128 libcall lowering, after D72341 this will cause
the libcall to be emitted twice.




More information about the All-commits mailing list