[all-commits] [llvm/llvm-project] 41f4df: [libcxx] Force-cache LIBCXX_CXX_ABI_LIBRARY_PATH
Sergej Jaskiewicz via All-commits
all-commits at lists.llvm.org
Fri Jan 10 01:57:23 PST 2020
Branch: refs/heads/master
Home: https://github.com/llvm/llvm-project
Commit: 41f4dfd63ea0fe995ddfba1838aa5ed972cc1377
https://github.com/llvm/llvm-project/commit/41f4dfd63ea0fe995ddfba1838aa5ed972cc1377
Author: Sergej Jaskiewicz <jaskiewiczs at icloud.com>
Date: 2020-01-10 (Fri, 10 Jan 2020)
Changed paths:
M libcxx/test/CMakeLists.txt
Log Message:
-----------
[libcxx] Force-cache LIBCXX_CXX_ABI_LIBRARY_PATH
Summary:
The `LIBCXX_CXX_ABI_LIBRARY_PATH` CMake variable is cached once in
libcxx/cmake/Modules/HandleLibCXXABI.cmake in the `setup_abi_lib` macro,
and then cached again in libcxx/test/CMakeLists.txt. There, if it is
not set to a value, it is by default set to `LIBCXX_LIBRARY_DIR`.
However, this new value is not actually cached, because the old (empty)
value has been already cached. Use the `FORCE` CMake flag so that it
is saved to the cache.
This should not break anything, because the code changed here previously
had no effect, when it should have.
Reviewers: jroelofs, bcraig, ldionne, EricWF, mclow.lists, vvereschaka, eastig
Reviewed By: vvereschaka
Subscribers: mgorny, christof, dexonsmith, libcxx-commits
Tags: #libc
Differential Revision: https://reviews.llvm.org/D69169
More information about the All-commits
mailing list