[all-commits] [llvm/llvm-project] ffd0f1: [clangd] Improve type printing in hover

[kadir çetinkaya via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: ffd0f116754c36146bb21a01b047782ce8a01e2e
      https://github.com/llvm/llvm-project/commit/ffd0f116754c36146bb21a01b047782ce8a01e2e
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2020-01-10 (Fri, 10 Jan 2020)

  Changed paths:
    M clang-tools-extra/clangd/Hover.cpp
    M clang-tools-extra/clangd/unittests/HoverTests.cpp

  Log Message:
  -----------
  [clangd] Improve type printing in hover

Summary:
Do not include tag keywords when printing types for symbol names, as it
will come from SymbolKind.
Also suppress them while printing definitions to prevent them occuring in
template arguments.
Make use of `getAsString`, instead of `print` in all places to have a consistent
style across the file.

Reviewers: sammccall

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D72450


  Commit: abfa27e4f04dd84774bcfe15783942e21be391a5
      https://github.com/llvm/llvm-project/commit/abfa27e4f04dd84774bcfe15783942e21be391a5
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2020-01-10 (Fri, 10 Jan 2020)

  Changed paths:
    M clang-tools-extra/clangd/FormattedString.cpp
    M clang-tools-extra/clangd/unittests/FormattedStringTests.cpp

  Log Message:
  -----------
  [clangd] Fix markdown rendering in VSCode

Summary:
Eventough it is OK to have a new line without any preceding spaces in
some markdown specifications, VSCode requires two spaces before a new line to
break a line inside a paragraph.

Reviewers: sammccall, ilya-biryukov

Subscribers: MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D72462


Compare: https://github.com/llvm/llvm-project/compare/45c4b08d8228...abfa27e4f04d