[all-commits] [llvm/llvm-project] 1444e6: Re-apply "[ELF] Allow getErrPlace() to work before...

Alexander Richardson via All-commits all-commits at lists.llvm.org
Thu Jan 9 12:46:26 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 1444e6e2e6f6b76cc9d5aab8b1877926aa6d5597
      https://github.com/llvm/llvm-project/commit/1444e6e2e6f6b76cc9d5aab8b1877926aa6d5597
  Author: Alex Richardson <Alexander.Richardson at cl.cam.ac.uk>
  Date:   2020-01-09 (Thu, 09 Jan 2020)

  Changed paths:
    M lld/ELF/Target.cpp
    M lld/test/ELF/mips-jalr-non-functions.s

  Log Message:
  -----------
  Re-apply "[ELF] Allow getErrPlace() to work before Out::bufferStart is set"

This time with a fix for the UBSAN failure.

Differential Revision: https://reviews.llvm.org/D70659


  Commit: 646ca7d7e72e8408b3fa3472018eb9d1c2643ff5
      https://github.com/llvm/llvm-project/commit/646ca7d7e72e8408b3fa3472018eb9d1c2643ff5
  Author: Alex Richardson <Alexander.Richardson at cl.cam.ac.uk>
  Date:   2020-01-09 (Thu, 09 Jan 2020)

  Changed paths:
    M llvm/lib/Target/Mips/MipsDelaySlotFiller.cpp
    A llvm/test/CodeGen/Mips/delay-slot-filler-bundled-insts-def-use.mir

  Log Message:
  -----------
  MipsDelaySlotFiller: Update registers def-uses for BUNDLE instructions

Summary:
In commit b91f239485fb7bb8d29be3e0b60660a2de7570a9 I updated the
MipsDelaySlotFiller to skip BUNDLE instructions.
However, in addition to not considering BUNDLE instructions for the delay
slot, we also need to ensure that the register def-use information is
updated. Not updating this information caused run-time crashes (when using
the out-of-tree CHERI backend) since later definitions could be overwritten
with earlier register values.

Reviewers: atanasyan
Reviewed By: atanasyan
Differential Revision: https://reviews.llvm.org/D72254


Compare: https://github.com/llvm/llvm-project/compare/4e003aad42d9...646ca7d7e72e


More information about the All-commits mailing list