[all-commits] [llvm/llvm-project] fb76c7: [libcxxabi] Allow tests to link with static libc++...
Sergej Jaskiewicz via All-commits
all-commits at lists.llvm.org
Thu Jan 9 08:02:24 PST 2020
Branch: refs/heads/master
Home: https://github.com/llvm/llvm-project
Commit: fb76c7934dce2ede7e04097edb455eba58f6ebfd
https://github.com/llvm/llvm-project/commit/fb76c7934dce2ede7e04097edb455eba58f6ebfd
Author: Sergej Jaskiewicz <jaskiewiczs at icloud.com>
Date: 2020-01-09 (Thu, 09 Jan 2020)
Changed paths:
M libcxxabi/CMakeLists.txt
M libcxxabi/test/CMakeLists.txt
M libcxxabi/test/lit.site.cfg.in
Log Message:
-----------
[libcxxabi] Allow tests to link with static libc++abi/libc++ even if the shared version is present
Summary:
Right now the only way to force libc++abi tests to link with the static version of libc++abi is to set `LIBCXXABI_ENABLE_SHARED` to `OFF`. However, this doesn't work when libc++abi is built as standalone project because of [this](https://github.com/llvm/llvm-project/blob/54c522420347e58aa7bae1892cf5c5672b57c875/libcxxabi/CMakeLists.txt#L503-L519).
This change allows specifying the version of the library for tests to link with.
This is useful for remote testing, for example, with `SSHExecutor`, where we _have_ to link with libc++abi statically.
Two new CMake options are introduced here: `LIBCXXABI_LINK_TESTS_WITH_SHARED_LIBCXXABI` and `LIBCXXABI_LINK_TESTS_WITH_SHARED_LIBCXX`. They can be set to `OFF` to tell the test utility to link tests with the static libraries.
It shouldn't break anything, because the default values of these options are set such that the test utility will behave the same way.
Reviewers: EricWF, mclow.lists, phosek, mehdi_amini, ldionne, jroelofs, bcraig
Subscribers: mgorny, christof, ldionne, libcxx-commits
Tags: #libc
Differential Revision: https://reviews.llvm.org/D71894
More information about the All-commits
mailing list