[all-commits] [llvm/llvm-project] 48b14e: [MLIR] Fix ML IR build on Windows with Visual Studio

Stella Stamenova via All-commits all-commits at lists.llvm.org
Wed Jan 8 10:49:19 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 48b14e58abc57cfea7bcdc0d7165686f135a2ebd
      https://github.com/llvm/llvm-project/commit/48b14e58abc57cfea7bcdc0d7165686f135a2ebd
  Author: Stella Stamenova <stilis at microsoft.com>
  Date:   2020-01-08 (Wed, 08 Jan 2020)

  Changed paths:
    M mlir/CMakeLists.txt

  Log Message:
  -----------
  [MLIR] Fix ML IR build on Windows with Visual Studio

Summary: Right now the path for each lib in whole_archive_link when MSVC is used as the compiler is not a full path - and it's not even the correct path when VS is used to build. This patch sets the lib path to a full path using CMAKE_CFG_INTDIR which means the path will be correct regardless of whether ninja, make or VS is used and it will always be a full path.

Reviewers: denis13, jpienaar

Reviewed By: jpienaar

Subscribers: mgorny, mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, nicolasvasilache, arpith-jacob, mgester, lucyrfox, llvm-commits, asmith

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D72403




More information about the All-commits mailing list