[all-commits] [llvm/llvm-project] b841e1: [ELF] Delete an unused special rule from isStaticL...

Fangrui Song via All-commits all-commits at lists.llvm.org
Wed Jan 8 09:43:04 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: b841e119d77ed0502e3a2e710f26a899bef28b3c
      https://github.com/llvm/llvm-project/commit/b841e119d77ed0502e3a2e710f26a899bef28b3c
  Author: Fangrui Song <maskray at google.com>
  Date:   2020-01-08 (Wed, 08 Jan 2020)

  Changed paths:
    M lld/ELF/Relocations.cpp

  Log Message:
  -----------
  [ELF] Delete an unused special rule from isStaticLinkTimeConstant. NFC

Weak undefined symbols are preemptible after D71794.

  if (sym.isPreemptible)
    return false;
  if (!config->isPic)
    return true;
  // isPic means includeInDynsym is true after D71794.

  ...

  // We can delete this if because it can never be true.
  if (sym.isUndefWeak)
    return true;

Differential Revision: https://reviews.llvm.org/D71795




More information about the All-commits mailing list