[all-commits] [llvm/llvm-project] 518597: [lldb] Remove default llvm::Triple argument from C...

[Raphael Isemann via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 518597c1737646ea1f087c1fa43109f689adf7a6
      https://github.com/llvm/llvm-project/commit/518597c1737646ea1f087c1fa43109f689adf7a6
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2020-01-08 (Wed, 08 Jan 2020)

  Changed paths:
    M lldb/include/lldb/Symbol/ClangASTContext.h
    M lldb/unittests/SymbolFile/DWARF/DWARFASTParserClangTests.cpp

  Log Message:
  -----------
  [lldb] Remove default llvm::Triple argument from ClangASTContext constructor

Creating an ASTContext with an unknown triple is rarely a good idea (as usually
all our ASTs have a valid triple that is either from the host or the target) and the
default argument makes it far to easy to implicitly create such an AST. Let's
remove it and force people to pass a triple.

The only place where we don't pass a triple is a DWARFASTParserClangTests
where we now just pass the host triple instead (the test doesn't depend on any
triple so this shouldn't change anything).