[all-commits] [llvm/llvm-project] e34801: [ARM][MVE] VPT Blocks: findVCMPToFoldIntoVPS

sjoerdmeijer via All-commits all-commits at lists.llvm.org
Tue Jan 7 05:58:55 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e34801c8e6df11b802f58b202f2ce6598734f040
      https://github.com/llvm/llvm-project/commit/e34801c8e6df11b802f58b202f2ce6598734f040
  Author: Sjoerd Meijer <sjoerd.meijer at arm.com>
  Date:   2020-01-07 (Tue, 07 Jan 2020)

  Changed paths:
    M llvm/lib/CodeGen/ReachingDefAnalysis.cpp
    M llvm/lib/Target/ARM/MVEVPTBlockPass.cpp
    M llvm/test/CodeGen/ARM/O3-pipeline.ll
    A llvm/test/CodeGen/Thumb2/mve-vpt-block-fold-vcmp.mir
    A llvm/test/CodeGen/Thumb2/mve-vpt-block-optnone.mir

  Log Message:
  -----------
  [ARM][MVE] VPT Blocks: findVCMPToFoldIntoVPS

This is a recommit of D71330, but with a few things fixed and changed:

1) ReachingDefAnalysis: this was not running with optnone as it was checking
skipFunction(), which other analysis passes don't do. I guess this is a
copy-paste from a codegen pass.
2) VPTBlockPass: here I've added skipFunction(), because like most/all
optimisations, we don't want to run this with optnone.

This fixes the issues with the initial/previous commit: the VPTBlockPass was
running with optnone, but ReachingDefAnalysis wasn't, and so VPTBlockPass was
crashing querying ReachingDefAnalysis.

I've added test case mve-vpt-block-optnone.mir to check that we don't run
VPTBlock with optnone.

Differential Revision: https://reviews.llvm.org/D71470




More information about the All-commits mailing list