[all-commits] [llvm/llvm-project] f1c85e: AMDGPU/GlobalISel: Select more G_EXTRACTs correctly

Matt Arsenault via All-commits all-commits at lists.llvm.org
Mon Jan 6 08:10:20 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: f1c85ecdfcc3b1c3500ab91ac7c1fb9d2cd8aa78
      https://github.com/llvm/llvm-project/commit/f1c85ecdfcc3b1c3500ab91ac7c1fb9d2cd8aa78
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-01-06 (Mon, 06 Jan 2020)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
    M llvm/test/CodeGen/AMDGPU/GlobalISel/inst-select-extract.mir

  Log Message:
  -----------
  AMDGPU/GlobalISel: Select more G_EXTRACTs correctly

This assumed a 32-bit extract size, which would produce invalid copies
with 64-bit extracts. Handle the easy case. Ideally we would have a
way to get the proper subreg index for any 32-bit offset, but there
should probably be a tablegenerated way of getting the subreg index
for any size and offset.




More information about the All-commits mailing list