[all-commits] [llvm/llvm-project] 5eed4e: AMDGPU/GlobalISel: Implement applyMappingImpl less...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Sat Jan 4 09:36:13 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 5eed4e2664aa7187f46eb12e45a376d7ab7dd308
      https://github.com/llvm/llvm-project/commit/5eed4e2664aa7187f46eb12e45a376d7ab7dd308
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-01-04 (Sat, 04 Jan 2020)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp

  Log Message:
  -----------
  AMDGPU/GlobalISel: Implement applyMappingImpl less incorrectly

We're checking the current register bank of the registers in the
instruction, but the mapping may have inserted cross bank copies and
is expecting to replace the registers.

We mostly get away with this currently, because VGPR->SGPR copies are
illegal, and we assume this won't happen. In a future change, we'll
start relying on more cross register bank copies being inserted, and
this starts to break down.




More information about the All-commits mailing list