[all-commits] [llvm/llvm-project] 2306f4: [X86] Update MaxIndex test in x86-cmov-converter.l...

topperc via All-commits all-commits at lists.llvm.org
Sat Jan 4 00:03:24 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 2306f43ccb46627b92aa0bb48b96437984c50c01
      https://github.com/llvm/llvm-project/commit/2306f43ccb46627b92aa0bb48b96437984c50c01
  Author: Craig Topper <craig.topper at gmail.com>
  Date:   2020-01-03 (Fri, 03 Jan 2020)

  Changed paths:
    M llvm/test/CodeGen/X86/x86-cmov-converter.ll

  Log Message:
  -----------
  [X86] Update MaxIndex test in x86-cmov-converter.ll to return the index and not use the index to look up the array after the loop.

This represents a more realistic version of the code being tested.
The cmov converter doesn't look at the code after the loop so
it doesn't matter for what's being tested.

But as noted in this twitter thread https://twitter.com/trav_downs/status/1213311159413161987
gcc can turn the previous MaxIndex code into the MaxValue code. So
returning the index makes it a distinct case.




More information about the All-commits mailing list