[all-commits] [llvm/llvm-project] f38234: [lldb/CMake] Fix variable naming in FindLibEdit

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Thu Jan 2 13:41:04 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: f38234ed8b579230a3742317ffd5fb95514d9638
      https://github.com/llvm/llvm-project/commit/f38234ed8b579230a3742317ffd5fb95514d9638
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-01-02 (Thu, 02 Jan 2020)

  Changed paths:
    M lldb/cmake/modules/FindLibEdit.cmake
    M lldb/cmake/modules/LLDBConfig.cmake
    M lldb/source/Core/CMakeLists.txt
    M lldb/source/Host/CMakeLists.txt
    M lldb/source/Interpreter/CMakeLists.txt
    M lldb/source/Plugins/ScriptInterpreter/Python/CMakeLists.txt

  Log Message:
  -----------
  [lldb/CMake] Fix variable naming in FindLibEdit

The current FOUND_VAR for FindLibEdit is libedit_FOUND but wasn't set by
find_package_handle_standard_args. However this isn't valid for the
package name.

  The argument for FOUND_VAR is "libedit_FOUND", but only "LibEdit_FOUND" and
  "LIBEDIT_FOUND" are valid names.

This fixes all the variables set by FindLibEdit to match the desired
naming scheme.


  Commit: f83801fb2a4064d666cf8c17d716376a99e4a555
      https://github.com/llvm/llvm-project/commit/f83801fb2a4064d666cf8c17d716376a99e4a555
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-01-02 (Thu, 02 Jan 2020)

  Changed paths:
    M lldb/cmake/modules/LLDBConfig.cmake

  Log Message:
  -----------
  [lldb/CMake] Print whether an optional dependency was enabled.

Use a status message to convey whether an optional dependency was found
or not. With the auto-detection code it's not longer as simple as
checking the CMake cache.


Compare: https://github.com/llvm/llvm-project/compare/982695c0693f...f83801fb2a40


More information about the All-commits mailing list