[all-commits] [llvm/llvm-project] 831898: [SelectionDAG] Fix copy/paste mistake in comment. NFC

topperc via All-commits all-commits at lists.llvm.org
Mon Dec 30 19:36:24 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 831898ff8acd4f5d8c5a644e6e566cefa23e2d6c
      https://github.com/llvm/llvm-project/commit/831898ff8acd4f5d8c5a644e6e566cefa23e2d6c
  Author: Craig Topper <craig.topper at gmail.com>
  Date:   2019-12-30 (Mon, 30 Dec 2019)

  Changed paths:
    M llvm/include/llvm/CodeGen/TargetLowering.h

  Log Message:
  -----------
  [SelectionDAG] Fix copy/paste mistake in comment. NFC

I think this was copied from scalarizeVectorLoad where that is
what happens.


  Commit: 787e078f3ec89bce82a789d2ee01beecc98db4d7
      https://github.com/llvm/llvm-project/commit/787e078f3ec89bce82a789d2ee01beecc98db4d7
  Author: Craig Topper <craig.topper at gmail.com>
  Date:   2019-12-30 (Mon, 30 Dec 2019)

  Changed paths:
    M llvm/include/llvm/CodeGen/TargetLowering.h
    M llvm/lib/CodeGen/SelectionDAG/LegalizeVectorOps.cpp
    M llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
    M llvm/lib/Target/AMDGPU/R600ISelLowering.cpp
    M llvm/lib/Target/AMDGPU/SIISelLowering.cpp

  Log Message:
  -----------
  [TargetLowering][AMDGPU] Make scalarizeVectorLoad return a pair of SDValues instead of creating a MERGE_VALUES node. NFCI

This allows us to clean up some places that were peeking through
the MERGE_VALUES node after the call. By returning the SDValues
directly, we can clean that up.

Unfortunately, there are several call sites in AMDGPU that wanted
the MERGE_VALUES and now need to create their own.


Compare: https://github.com/llvm/llvm-project/compare/991f7abdfc55...787e078f3ec8


More information about the All-commits mailing list