[all-commits] [llvm/llvm-project] 8b23b2: [CodeGen] Use CreateFNeg in buildFMulAdd

topperc via All-commits all-commits at lists.llvm.org
Mon Dec 30 13:37:39 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 8b23b2bbd9622c5f079a71c7078d167052f6a70c
      https://github.com/llvm/llvm-project/commit/8b23b2bbd9622c5f079a71c7078d167052f6a70c
  Author: Craig Topper <craig.topper at intel.com>
  Date:   2019-12-30 (Mon, 30 Dec 2019)

  Changed paths:
    M clang/lib/CodeGen/CGExprScalar.cpp
    M clang/test/CodeGen/fp-contract-pragma.cpp

  Log Message:
  -----------
  [CodeGen] Use CreateFNeg in buildFMulAdd

We have an fneg instruction now and should use it instead of the fsub -0.0 idiom. Looks like we had no test that showed that we handled the negation cases here so I've added new tests.

Differential Revision: https://reviews.llvm.org/D72010


  Commit: 70f8dd4cf604b2be3488895ef0d261154c1c1124
      https://github.com/llvm/llvm-project/commit/70f8dd4cf604b2be3488895ef0d261154c1c1124
  Author: Craig Topper <craig.topper at intel.com>
  Date:   2019-12-30 (Mon, 30 Dec 2019)

  Changed paths:
    M clang/lib/CodeGen/CGBuiltin.cpp
    A clang/test/CodeGen/complex-builtins-2.c

  Log Message:
  -----------
  [CodeGen] Use IRBuilder::CreateFNeg for __builtin_conj

This replaces the fsub -0.0 idiom with an fneg instruction. We didn't see to have a test that showed the current codegen. Just some tests for constant folding and a test that was only checking the declare lines for libcalls. The latter just checked that we did not have a declare for @conj when using __builtin_conj.

Differential Revision: https://reviews.llvm.org/D72012


Compare: https://github.com/llvm/llvm-project/compare/07be32961a69...70f8dd4cf604


More information about the All-commits mailing list