[all-commits] [llvm/llvm-project] 599d07: [X86] Remove dyn_casts to ConstantSDNode for opera...

topperc via All-commits all-commits at lists.llvm.org
Sun Dec 29 18:02:48 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 599d07091002b20be5e2b12b256782e0dd0df998
      https://github.com/llvm/llvm-project/commit/599d07091002b20be5e2b12b256782e0dd0df998
  Author: Craig Topper <craig.topper at gmail.com>
  Date:   2019-12-29 (Sun, 29 Dec 2019)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp

  Log Message:
  -----------
  [X86] Remove dyn_casts to ConstantSDNode for operand 1 of X86ISD::VSRLI/VSRAI/VSRLI. Use getConstantOperandVal and APInt operations.

These nodes should only ever be formed with an i8 TargetConstant
so we don't need to check for it to be a constant. It's also
always 8-bits so we don't need to use APInt compare functions.


  Commit: b2f19320dc1ca82acd3939b18c5c73ee8833b735
      https://github.com/llvm/llvm-project/commit/b2f19320dc1ca82acd3939b18c5c73ee8833b735
  Author: Craig Topper <craig.topper at gmail.com>
  Date:   2019-12-29 (Sun, 29 Dec 2019)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp

  Log Message:
  -----------
  [X86] Use isOneConstant to simplify some code. NFC


  Commit: 266cd7717c8126213a7560d26da5495053be90c0
      https://github.com/llvm/llvm-project/commit/266cd7717c8126213a7560d26da5495053be90c0
  Author: Craig Topper <craig.topper at gmail.com>
  Date:   2019-12-29 (Sun, 29 Dec 2019)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp

  Log Message:
  -----------
  [X86] Use APInt::isOneValue and ConstantSDNode::isOne. NFC

These are implemented slightly more efficiently than comparing
to 1 in the case that the value is more than 64 bits.


Compare: https://github.com/llvm/llvm-project/compare/5edb40c0220e...266cd7717c81


More information about the All-commits mailing list