[all-commits] [llvm/llvm-project] 8fcce5: Revert "[msan] Intercept qsort, qsort_r."

Reid Kleckner via All-commits all-commits at lists.llvm.org
Fri Dec 27 11:27:10 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 8fcce5ac73d49981656d9126e6c88391c1f6bf01
      https://github.com/llvm/llvm-project/commit/8fcce5ac73d49981656d9126e6c88391c1f6bf01
  Author: Reid Kleckner <rnk at google.com>
  Date:   2019-12-27 (Fri, 27 Dec 2019)

  Changed paths:
    M compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors.inc
    M compiler-rt/lib/sanitizer_common/sanitizer_platform_interceptors.h
    R compiler-rt/test/msan/qsort.cpp

  Log Message:
  -----------
  Revert "[msan] Intercept qsort, qsort_r."

This reverts commit 7a9ebe95125ea87a494d0c18f44f10bd70e12188, and
dependent commit 54c522420347e58aa7bae1892cf5c5672b57c875, which
disables qsort interception for some iOS platforms.

After this change, the -Nolibc sanitizer common test binary crashes on
startup on my regular Linux workstation, as well as on our bots:
https://ci.chromium.org/p/chromium/builders/try/linux_upload_clang/740

 ********************
  Failing Tests (1):
       SanitizerCommon-Unit ::
       ./Sanitizer-x86_64-Test/SanitizerCommon.NolibcMain

Loading it up in gdb shows that it crashes during relocation processing,
which suggests that some glibc loader versions do not support the
THREADLOCAL data added in this interceptor.




More information about the All-commits mailing list