[all-commits] [llvm/llvm-project] cda94d: [mlir] Floating constants for import-llvm

ftynse via All-commits all-commits at lists.llvm.org
Fri Dec 27 02:48:29 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: cda94d3e8ae3679eb75988afc85faa1e14068a83
      https://github.com/llvm/llvm-project/commit/cda94d3e8ae3679eb75988afc85faa1e14068a83
  Author: Alex Zinenko <zinenko at google.com>
  Date:   2019-12-27 (Fri, 27 Dec 2019)

  Changed paths:
    M mlir/lib/Target/LLVMIR/ConvertFromLLVMIR.cpp
    M mlir/test/Target/import.ll

  Log Message:
  -----------
  [mlir] Floating constants for import-llvm

Summary:
`mlir-translate -import-llvm test.ll`  was going into segmentation fault if `test.ll` had `float` or `double` constants.
For example,
```
%3 = fadd double 3.030000e+01, %0
```
Now, it is handled in `Importer::getConstantAsAttr` (similar behaviour as normal integers)
Added tests for FP arithmetic

Reviewers: ftynse, mehdi_amini

Reviewed By: ftynse, mehdi_amini

Subscribers: shauheen, mehdi_amini, rriddle, jpienaar, burmako, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D71912




More information about the All-commits mailing list