[all-commits] [llvm/llvm-project] 287307: Partially revert "Add initial tests for update_{ll...

Reid Kleckner via All-commits all-commits at lists.llvm.org
Thu Dec 26 08:55:24 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 287307a0c60b68099d5f9dd22ac1db2a42593533
      https://github.com/llvm/llvm-project/commit/287307a0c60b68099d5f9dd22ac1db2a42593533
  Author: Reid Kleckner <rnk at google.com>
  Date:   2019-12-26 (Thu, 26 Dec 2019)

  Changed paths:
    M llvm/test/tools/UpdateTestChecks/lit.local.cfg
    R llvm/test/tools/UpdateTestChecks/update_cc_test_checks/Inputs/mangled_names.c
    R llvm/test/tools/UpdateTestChecks/update_cc_test_checks/Inputs/mangled_names.c.expected
    R llvm/test/tools/UpdateTestChecks/update_cc_test_checks/Inputs/mangled_names.c.funcsig.expected
    R llvm/test/tools/UpdateTestChecks/update_cc_test_checks/lit.local.cfg
    R llvm/test/tools/UpdateTestChecks/update_cc_test_checks/mangled_names.test

  Log Message:
  -----------
  Partially revert "Add initial tests for update_{llc_,cc_,}test_checks.py"

This reverts part of commit 240aff80e0e59b79779d046b3275904fc0750d59.
It reverts cc802ea67beb66d2f8a935e647c3aedcf7848211.

We currently run LLVM tests in environments where python3 exists on
PATH, but it is broken. I don't think PATH discovery is a strong enough
signal that a working Python 3 installation exists.

If this will be the way forward, IMO we should follow the direction of
debug-info-tests, and use CMake's PYTHON_EXECUTABLE, which in the near
future will be a known-to-work Python 3 executable. If it's not Python
3, then we don't have to run this test.




More information about the All-commits mailing list