[all-commits] [llvm/llvm-project] e40ac7: [lldb] Remove DWARFUnit::AppendDIEsWithTag

Pavel Labath via All-commits all-commits at lists.llvm.org
Mon Dec 23 06:49:45 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e40ac74dacda99ff6330945f0f105252b7c28c9c
      https://github.com/llvm/llvm-project/commit/e40ac74dacda99ff6330945f0f105252b7c28c9c
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2019-12-23 (Mon, 23 Dec 2019)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.h
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

  Log Message:
  -----------
  [lldb] Remove DWARFUnit::AppendDIEsWithTag

This function is not very useful, as it's forcing a materialization of
the returned DIEs, and calling it is not substantially simpler than just
iterating over the DIEs manually. Delete it, and rewrite the single
caller.




More information about the All-commits mailing list