[all-commits] [llvm/llvm-project] 46f02f: [lldb/DWARF] Fix hostname-stripping logic

Pavel Labath via All-commits all-commits at lists.llvm.org
Mon Dec 23 05:53:02 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 46f02fc922e053006e34d860e9efaf29c88d8ba3
      https://github.com/llvm/llvm-project/commit/46f02fc922e053006e34d860e9efaf29c88d8ba3
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2019-12-23 (Mon, 23 Dec 2019)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
    A lldb/test/Shell/SymbolFile/DWARF/debug_line-relative_path.s

  Log Message:
  -----------
  [lldb/DWARF] Fix hostname-stripping logic

This bit of code is trying to strip everything up to the first colon
from all debug info paths, as dwarf2 recommends this syntax for storing
the compilation host name. However, this code was too eager, and it
ended up stripping the entire compilation directory, if it did not
contain a forward slash (or a "x:\").

Normally this does not matter, as all absolute paths will contain one of
these patterns, but this does not have to be the case in case the debug
info is produced by "clang -fdebug-compilation-dir", which can end up
producing a relative compilation directory with no slashes (this is one
of the techniques for producing "relocatable" debug info).




More information about the All-commits mailing list