[all-commits] [llvm/llvm-project] 810c3c: ThreadPlanTracer::TracingStarted can't call vi...

[jimingham via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 810c3cfa664b38b27bc30afaadab3d775cb17922
      https://github.com/llvm/llvm-project/commit/810c3cfa664b38b27bc30afaadab3d775cb17922
  Author: Jim Ingham <jingham at apple.com>
  Date:   2019-12-20 (Fri, 20 Dec 2019)

  Changed paths:
    M lldb/source/Target/ThreadPlanTracer.cpp

  Log Message:
  -----------
      ThreadPlanTracer::TracingStarted can't call virtual methods on Thread.

    TracingStarted gets called in the Thread constructor, which means you can't
    call a virtual method of the class.  So delay setting up the m_register_values
    till you need them.  NFC as lldb just crashes if you don't do this.

    The thread tracing is an only occasionally useful feature, and it only sort
    of works.  I'm not adding tests etc. at this point, I'm just poking at it a
    bit.  If I get it working better I'll write tests and so forth.