[all-commits] [llvm/llvm-project] c2377e: [clang][Tooling] Prefer -x over -std when interpol...

[kadir çetinkaya via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c2377eae286bbe616267bef772ee736b030dd007
      https://github.com/llvm/llvm-project/commit/c2377eae286bbe616267bef772ee736b030dd007
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2019-12-20 (Fri, 20 Dec 2019)

  Changed paths:
    M clang/lib/Tooling/InterpolatingCompilationDatabase.cpp
    M clang/unittests/Tooling/CompilationDatabaseTest.cpp

  Log Message:
  -----------
  [clang][Tooling] Prefer -x over -std when interpolating

Summary:
Currently interpolation logic prefers -std over -x. But the latter is a
more strong signal, so this patch inverts the order and only makes use of -std
if -x didn't exist.

Fixes https://github.com/clangd/clangd/issues/185

Thanks @sammccall for tracking this down!

Reviewers: sammccall

Subscribers: ilya-biryukov, usaxena95, cfe-commits, sammccall

Tags: #clang

Differential Revision: https://reviews.llvm.org/D71727