[all-commits] [llvm/llvm-project] 9b6faf: [X86] Directly call EmitTest in two places instead...

[topperc via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 9b6fafa3990fb5963f0558d13d53abc461fb3f29
      https://github.com/llvm/llvm-project/commit/9b6fafa3990fb5963f0558d13d53abc461fb3f29
  Author: Craig Topper <craig.topper at gmail.com>
  Date:   2019-12-19 (Thu, 19 Dec 2019)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp

  Log Message:
  -----------
  [X86] Directly call EmitTest in two places instead of creating a null constant and calling EmitCmp. NFCI

EmitCmp will just immediately call EmitTest and discard the null
constant only to have EmitTest create it again if it doesn't fold.

So just skip all that and go directly to EmitTest.


  Commit: bf507d4259c389cc21d44760b8ebf462edd8e5d0
      https://github.com/llvm/llvm-project/commit/bf507d4259c389cc21d44760b8ebf462edd8e5d0
  Author: Craig Topper <craig.topper at gmail.com>
  Date:   2019-12-19 (Thu, 19 Dec 2019)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp
    M llvm/lib/Target/X86/X86ISelLowering.h

  Log Message:
  -----------
  [X86] Make EmitCmp into a static function and explicitly return chain result for STRICT_FCMP. NFCI

The only thing its getting from the X86TargetLowering class is
the subtarget which we can easily pass. This function only has
one call site now since this might help the compiler inline it.

Explicitly return both the flag result and the chain result for
STRICT_FCMP nodes. This removes an assumption in the caller that
getValue(1) is the right way to get the chain.


Compare: https://github.com/llvm/llvm-project/compare/07ac3145ccd5...bf507d4259c3