[all-commits] [llvm/llvm-project] 29d8c2: [LLD] [COFF] Fix reporting duplicate errors for ab...

[Martin Storsjö via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 29d8c27c65289d1ed370861ff75f309a689a22cb
      https://github.com/llvm/llvm-project/commit/29d8c27c65289d1ed370861ff75f309a689a22cb
  Author: Martin Storsjö <martin at martin.st>
  Date:   2019-12-19 (Thu, 19 Dec 2019)

  Changed paths:
    M lld/COFF/SymbolTable.cpp
    A lld/test/COFF/duplicate-absolute.s

  Log Message:
  -----------
  [LLD] [COFF] Fix reporting duplicate errors for absolute symbols

Previously this caused crashes in the reportDuplicate method.

A DefinedAbsolute doesn't have any InputFile attached to it, so we
can't report the file for the original symbol.

We could add an InputFile argument to SymbolTable::addAbsolute
only for the sake of error reporting, but even then it'd be assymetrical,
only pointing out the file containing the new conflicting definition,
not the original one.

Differential Revision: https://reviews.llvm.org/D71679


  Commit: f20fc65887e2085332d111ee0b05736794423c72
      https://github.com/llvm/llvm-project/commit/f20fc65887e2085332d111ee0b05736794423c72
  Author: Martin Storsjö <martin at martin.st>
  Date:   2019-12-19 (Thu, 19 Dec 2019)

  Changed paths:
    M clang/include/clang/AST/Decl.h

  Log Message:
  -----------
  [clang] Fix compilation with GCC < 8 for MinGW

GCC 7 and earlier, when targeting MinGW, seems to have a bug in
layout/size of bitfield structs if they contain a nested enum,
making the size of the struct 8 bytes, while we have a static assert
requiring it to be 4 bytes or less.

While this clearly is a GCC bug, the workaround (moving the enum out
of the bitfield) also is very nonintrusive and matches other existing
enums there.

Differential Revision: https://reviews.llvm.org/D71650


Compare: https://github.com/llvm/llvm-project/compare/200cce345dcf...f20fc65887e2