[all-commits] [llvm/llvm-project] 738b5c: Fix more VFS tests on Windows

amccarth-google via All-commits all-commits at lists.llvm.org
Wed Dec 18 11:38:38 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 738b5c9639b4323f75b03e21494bef13d9adfa86
      https://github.com/llvm/llvm-project/commit/738b5c9639b4323f75b03e21494bef13d9adfa86
  Author: Adrian McCarthy <amccarth at google.com>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M clang/test/VFS/vfsroot-include.c
    M clang/test/VFS/vfsroot-module.m
    M clang/test/VFS/vfsroot-with-overlay.c
    M llvm/include/llvm/Support/VirtualFileSystem.h
    M llvm/lib/Support/VirtualFileSystem.cpp

  Log Message:
  -----------
  Fix more VFS tests on Windows

Since VFS paths can be in either Posix or Windows style, we have to use
a more flexible definition of "absolute" path.

The key here is that FileSystem::makeAbsolute is now virtual, and the
RedirectingFileSystem override checks for either concept of absolute
before trying to make the path absolute by combining it with the current
directory.

Differential Revision: https://reviews.llvm.org/D70701


  Commit: 9d38fd8d0be3074af036e9e3e36489f5b854faf4
      https://github.com/llvm/llvm-project/commit/9d38fd8d0be3074af036e9e3e36489f5b854faf4
  Author: Adrian McCarthy <amccarth at google.com>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M clang/test/VFS/subframework-symlink.m

  Log Message:
  -----------
  [NFC] Update FIXME for one VFS test

The VFS/subframework-symlink.m test is still XFAIL on Windows, but for
a different reason than those fixed in PR43272, so I've updated the
PR number.


Compare: https://github.com/llvm/llvm-project/compare/12038be20ee6...9d38fd8d0be3


More information about the All-commits mailing list