[all-commits] [llvm/llvm-project] cfe316: [SelectionDAGBuilder] Use getConstant instead of g...

topperc via All-commits all-commits at lists.llvm.org
Wed Dec 18 10:45:02 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: cfe316007fb8492535d697717c24ce72621a8d5e
      https://github.com/llvm/llvm-project/commit/cfe316007fb8492535d697717c24ce72621a8d5e
  Author: Craig Topper <craig.topper at intel.com>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
    M llvm/test/CodeGen/X86/masked_gather.ll

  Log Message:
  -----------
  [SelectionDAGBuilder] Use getConstant instead of getTargetConstant to build the offset for struct types in getUniformBase.

getTargetConstant prevents any optimizations from operating on the
value and basically says its already been iseled. But since we
want the index to be in a register, this isn't true.

Prior to this we were generating a vbroadcast with an immediate
argument which is illegal and was flagged by the expensive checks
bot.




More information about the All-commits mailing list