[all-commits] [llvm/llvm-project] 7ea2e5: Revert "Temporarily Revert "[gicombiner] Add the M...

Daniel Sanders via All-commits all-commits at lists.llvm.org
Wed Dec 18 03:37:27 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 7ea2e5195a82bd9370d0b4362512b67c8b2cde80
      https://github.com/llvm/llvm-project/commit/7ea2e5195a82bd9370d0b4362512b67c8b2cde80
  Author: Daniel Sanders <daniel_l_sanders at apple.com>
  Date:   2019-12-18 (Wed, 18 Dec 2019)

  Changed paths:
    M llvm/include/llvm/ADT/iterator.h
    M llvm/test/TableGen/GICombinerEmitter/match-invalid.td
    A llvm/test/TableGen/GICombinerEmitter/parse-match-pattern.td
    M llvm/utils/TableGen/GICombinerEmitter.cpp
    M llvm/utils/TableGen/GlobalISel/CMakeLists.txt
    A llvm/utils/TableGen/GlobalISel/GIMatchDag.cpp
    A llvm/utils/TableGen/GlobalISel/GIMatchDag.h
    A llvm/utils/TableGen/GlobalISel/GIMatchDagEdge.cpp
    A llvm/utils/TableGen/GlobalISel/GIMatchDagEdge.h
    A llvm/utils/TableGen/GlobalISel/GIMatchDagInstr.cpp
    A llvm/utils/TableGen/GlobalISel/GIMatchDagInstr.h
    A llvm/utils/TableGen/GlobalISel/GIMatchDagOperands.cpp
    A llvm/utils/TableGen/GlobalISel/GIMatchDagOperands.h
    A llvm/utils/TableGen/GlobalISel/GIMatchDagPredicate.cpp
    A llvm/utils/TableGen/GlobalISel/GIMatchDagPredicate.h
    A llvm/utils/TableGen/GlobalISel/GIMatchDagPredicateDependencyEdge.cpp
    A llvm/utils/TableGen/GlobalISel/GIMatchDagPredicateDependencyEdge.h

  Log Message:
  -----------
  Revert "Temporarily Revert "[gicombiner] Add the MatchDag structure and parse instruction DAG's from the input""

This reverts commit e62e760f29567fe0841af870c65a4f8ef685d217.

The issue @uweigand raised should have been fixed by iterating over the
vector that owns the operand list data instead of the FoldingSet.

The MSVC issue raised by @thakis should have been fixed by relaxing the
regexes a little. I don't have a Windows machine available to test that so
I tested it by using `perl -p -e 's/0x([0-9a-f]+)/\U\1\E/g' to convert the
output of %p to the windows style.

I've guessed at the issue @phosek raised as there wasn't enough information
to investigate it. What I think is happening on that bot is the -debug
option isn't available because the second stage build is a release build.
I'm not sure why other release-mode bots didn't report it though.




More information about the All-commits mailing list