[all-commits] [llvm/llvm-project] 1e8918: [FPEnv] Remove unnecessary rounding mode argument ...

Ulrich Weigand via All-commits all-commits at lists.llvm.org
Tue Dec 17 12:11:21 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 1e89188d3537d419f6bdc3276ab8848adf6752f5
      https://github.com/llvm/llvm-project/commit/1e89188d3537d419f6bdc3276ab8848adf6752f5
  Author: Ulrich Weigand <ulrich.weigand at de.ibm.com>
  Date:   2019-12-17 (Tue, 17 Dec 2019)

  Changed paths:
    M clang/test/CodeGen/constrained-math-builtins.c
    M llvm/docs/LangRef.rst
    M llvm/include/llvm/IR/ConstrainedOps.def
    M llvm/include/llvm/IR/IRBuilder.h
    M llvm/include/llvm/IR/Intrinsics.td
    M llvm/test/CodeGen/ARM/fp-intrinsics.ll
    M llvm/test/CodeGen/PowerPC/ppcf128-constrained-fp-intrinsics.ll
    M llvm/test/CodeGen/PowerPC/vector-constrained-fp-intrinsics.ll
    M llvm/test/CodeGen/SystemZ/fp-strict-round-01.ll
    M llvm/test/CodeGen/SystemZ/fp-strict-round-02.ll
    M llvm/test/CodeGen/SystemZ/fp-strict-round-03.ll
    M llvm/test/CodeGen/SystemZ/vec-strict-max-01.ll
    M llvm/test/CodeGen/SystemZ/vec-strict-min-01.ll
    M llvm/test/CodeGen/SystemZ/vec-strict-round-01.ll
    M llvm/test/CodeGen/SystemZ/vec-strict-round-02.ll
    M llvm/test/CodeGen/SystemZ/vector-constrained-fp-intrinsics.ll
    M llvm/test/CodeGen/X86/fp128-libcalls-strict.ll
    M llvm/test/CodeGen/X86/vector-constrained-fp-intrinsics.ll

  Log Message:
  -----------
  [FPEnv] Remove unnecessary rounding mode argument for constrained intrinsics

The following intrinsics currently carry a rounding mode metadata argument:

    llvm.experimental.constrained.minnum
    llvm.experimental.constrained.maxnum
    llvm.experimental.constrained.ceil
    llvm.experimental.constrained.floor
    llvm.experimental.constrained.round
    llvm.experimental.constrained.trunc

This is not useful since the semantics of those intrinsics do not in any way
depend on the rounding mode. In similar cases, other constrained intrinsics
do not have the rounding mode argument. Remove it here as well.

Reviewed By: craig.topper

Differential Revision: https://reviews.llvm.org/D71218




More information about the All-commits mailing list