[all-commits] [llvm/llvm-project] 4becf6: [ASTImporter] Friend class decl should not be visi...

[Gabor Marton via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 4becf68c6f17fe143539ceac954b21175914e1c1
      https://github.com/llvm/llvm-project/commit/4becf68c6f17fe143539ceac954b21175914e1c1
  Author: Gabor Marton <gabor.marton at ericsson.com>
  Date:   2019-12-17 (Tue, 17 Dec 2019)

  Changed paths:
    M clang/lib/AST/ASTImporter.cpp
    M clang/unittests/AST/ASTImporterTest.cpp

  Log Message:
  -----------
  [ASTImporter] Friend class decl should not be visible in its context

Summary:
In the past we had to use DeclContext::makeDeclVisibleInContext to make
friend declarations available for subsequent lookup calls and this way
we could chain (redecl) the structurally equivalent decls.
By doing this we created an AST that improperly made declarations
visible in some contexts, so the AST was malformed.
Since we use the importer specific lookup this is no longer necessary,
because with that we can find every previous nodes.

Reviewers: balazske, a_sidorin, a.sidorin, shafik

Subscribers: rnkovacs, dkrupp, Szelethus, gamesh411, teemperor, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D71020