[all-commits] [llvm/llvm-project] 3d3e40: [libomptarget][nfc] Move omp locks under target_impl

[Jon Chesterfield via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 3d3e4076cd65007007ca639d4f99c0fa671c9f8e
      https://github.com/llvm/llvm-project/commit/3d3e4076cd65007007ca639d4f99c0fa671c9f8e
  Author: JonChesterfield <jonathanchesterfield at gmail.com>
  Date:   2019-12-17 (Tue, 17 Dec 2019)

  Changed paths:
    M openmp/libomptarget/deviceRTLs/amdgcn/src/amdgcn_interface.h
    M openmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.h
    M openmp/libomptarget/deviceRTLs/interface.h
    M openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt
    M openmp/libomptarget/deviceRTLs/nvptx/src/libcall.cu
    M openmp/libomptarget/deviceRTLs/nvptx/src/nvptx_interface.h
    A openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.cu
    M openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.h

  Log Message:
  -----------
  [libomptarget][nfc] Move omp locks under target_impl

Summary:
[libomptarget][nfc] Move omp locks under target_impl

These are likely to be target specific, even down to the lock_t which is
correspondingly moved out of interface.h. The alternative is to include
interface.h in target_impl which substantiatially increases the scope of
those symbols.

The current nvptx implementation deadlocks on amdgcn. The preferred
implementation for that arch is still under discussion - this change
leaves declarations in target_impl.

The functions could be inline for nvptx. I'd prefer to keep the internals
hidden in the target_impl translation unit, but will add the (possibly renamed)
macros to target_impl.h if preferred.

Reviewers: ABataev, jdoerfert, grokos

Reviewed By: jdoerfert

Subscribers: jvesely, mgorny, jfb, openmp-commits

Tags: #openmp

Differential Revision: https://reviews.llvm.org/D71574